typing: resultlog, pytester, longrepr #7601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Thanks @bluetech!
The type of longrepr is a union with 5 possibilities, which is not great IMO. Perhaps one day we can clean it up, at least this should make it a little easier.
Thanks! Indeed that's mighty confusing.
bluetech
force-pushed
the
typing-longrepr
branch
from
574b548 to
fbf251f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits are in service of the third, which type annotates the
TestReport/CollectRepor(and related)longreprfields. That would have caught #7559.The type of
longrepris a union with 5 possibilities, which is not great IMO. Perhaps one day we can clean it up, at least this should make it a little easier.